Improve JWT RegExp #236
Merged
Improve JWT RegExp #236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #236 +/- ##
=======================================
Coverage 92.60% 92.60%
=======================================
Files 15 15
Lines 1217 1217
=======================================
Hits 1127 1127
Misses 90 90 Continue to review full report at Codecov.
|
ghost
enabled auto-merge
|
Mind squashing the commits and a better commit message / PR title please? 🥺 |
- add new RegExp for JWT that check header and payload length and prefix
`eyJ` and `e`
- add valid/invalid examples
- This idea comes from observing that the minimum length of each parts of JWT is 20, 3, 43, respectively
```
Header
{"alg":"HS256"}
Payload
{}
```
-
auto-merge was automatically disabled
December 3, 2021 06:31
Head branch was pushed to by a user without write access
amadejpapez
approved these changes
Dec 3, 2021
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
Why do we need this pull request?
What GitHub issues does this fix?
Copy / paste of output